chore(deps): Move to cosmos-sdk v0.50 official release
#1296
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 84 84
Lines 4857 4857
=======================================
Hits 2358 2358
Misses 2325 2325
Partials 174 174 |
# Walkthrough
The changes primarily revolve around the restructuring and enhancement of the Cosmos SDK application's initialization and configuration process. The modifications involve the addition of new functions, import statements, and command initializations, along with significant alterations to the `NewRootCmd` function and the handling of client context and keyring.
# Changes
| File Path | Change Summary |
| --- | --- |
| e2e/testapp/.../commands.go | Added import statements, function definitions, and command initializations. Introduced `initCometBFTConfig` and `initAppConfig` functions for custom configuration setup. Defined `newApp` and `appExport` functions for application creation and export. |
| e2e/testapp/.../root.go | Made significant changes to `NewRootCmd` function, introducing `clientCtx` and `txConfig` variables, and modifying the initialization process. Introduced `ProvideClientContext` and `ProvideKeyring` functions. Removed `initCometBFTConfig` and `initAppConfig` functions. Updated `genesisCommand`, `queryCommand`, and `txCommand` functions, altering the command structure. |
# Poem
> 🍂 As the leaves fall, so does the old code,
> Replaced by the new, a sight to behold.
> With Cosmos SDK in our stride,
> We've taken the software for a joyride.
> 🚀 Launching new functions into the sky,
> Watching as the old bugs say goodbye.
> On this day, in code we trust,
> Making changes that are robust.
> 🐇 CodeRabbit hops with glee,
> Celebrating the changes, as easy as one, two, three!TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (11)
- build/tools/go.mod
- build/tools/go.sum
- cosmos/go.mod
- cosmos/go.sum
- e2e/precompile/go.mod
- e2e/precompile/go.sum
- e2e/testapp/go.mod
- e2e/testapp/go.sum
- eth/go.mod
- eth/go.sum
- go.work.sum
Files selected for processing (2)
- e2e/testapp/polard/cmd/commands.go (1 hunks)
- e2e/testapp/polard/cmd/root.go (3 hunks)
Files skipped from review due to trivial changes (1)
- e2e/testapp/polard/cmd/commands.go
Additional comments: 6
e2e/testapp/polard/cmd/root.go (6)
57-62: The
NewRootCmdfunction has been updated to includeclientCtxas a local variable. Ensure that this change doesn't break any existing functionality that relies on the previous version of this function.74-78: The
depinject.Providefunction now includesProvideClientContextandProvideKeyring. Ensure that these functions are correctly implemented and that they return the expected types.88-88: The
ethcryptocodec.RegisterInterfacesfunction is called withclientCtx.InterfaceRegistryas an argument. Ensure thatclientCtx.InterfaceRegistryis correctly initialized before this call.90-122: The
PersistentPreRunEfunction ofrootCmdhas been significantly modified. Ensure that these changes don't break any existing functionality that relies on the previous version of this function.134-162: The
ProvideClientContextfunction is introduced. Ensure that this function is correctly implemented and that it returns the expected type.164-171: The
ProvideKeyringfunction is introduced. Ensure that this function is correctly implemented and that it returns the expected type.
## Summary by CodeRabbit The existing bullet-point list is still valid based on the provided instructions. (cherry picked from commit 9eacb8c)
) (#1297) Co-authored-by: Devon Bear <[email protected]>
Summary by CodeRabbit
The existing bullet-point list is still valid based on the provided instructions.